Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate vault secrets into ServerDefinition class #20

Closed
andy-maier opened this issue Mar 30, 2021 · 0 comments · Fixed by #21
Closed

Integrate vault secrets into ServerDefinition class #20

andy-maier opened this issue Mar 30, 2021 · 0 comments · Fixed by #21
Assignees
@andy-maier
Milestone
0.6.0

Comments

@andy-maier
Copy link
Owner

A meaningful use of the ServerDefinition class in the server_definition fixture provided by the pytest-easy-server project requires that the vault secrets are made available in that class.

One possible approach is to have the server definition file reference the vault file and to load that too once the server definition file is loaded in ServerDefinitionFile. That would also simplify the options of the pytest plugin from specifying both files separately to specifying just the server definition file.
@andy-maier andy-maier self-assigned this Mar 30, 2021
@andy-maier andy-maier added this to the 0.6.0 milestone Mar 30, 2021
andy-maier added a commit that referenced this issue Mar 30, 2021
@andy-maier
Integrated vault access into server definition file
f8cba35 
Details:

* Integrated vault access into server definition file. The server definition
  files can now optionally specify the path name of a vault file. If specified,
  the vault file is loaded as well and the secrets for a server defined in
  the vault file are available in the ServerDefinition object as a new `secrets`
  property. (issue #20)

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
@andy-maier andy-maier linked a pull request Mar 30, 2021 that will close this issue
Integrated vault access into server definition file #21
Merged
andy-maier added a commit that referenced this issue Mar 30, 2021
@andy-maier
Integrated vault access into server definition file
0887b04 
Details:

* Integrated vault access into server definition file. The server definition
  files can now optionally specify the path name of a vault file. If specified,
  the vault file is loaded as well and the secrets for a server defined in
  the vault file are available in the ServerDefinition object as a new `secrets`
  property. (issue #20)

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
andy-maier added a commit that referenced this issue Mar 30, 2021
@andy-maier
Integrated vault access into server definition file
ba0331d 
Details:

* Integrated vault access into server definition file. The server definition
  files can now optionally specify the path name of a vault file. If specified,
  the vault file is loaded as well and the secrets for a server defined in
  the vault file are available in the ServerDefinition object as a new `secrets`
  property. (issue #20)

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
andy-maier added a commit that referenced this issue Mar 30, 2021
@andy-maier
Integrated vault access into server definition file
5e13595 
Details:

* Integrated vault access into server definition file. The server definition
  files can now optionally specify the path name of a vault file. If specified,
  the vault file is loaded as well and the secrets for a server defined in
  the vault file are available in the ServerDefinition object as a new `secrets`
  property. (issue #20)

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andy-maier andy-maier

Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Integrated vault access into server definition file andy-maier/easy-server
1 participant
@andy-maier