Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Countdown window sticks around after execution #4

Closed
Luke-Baker opened this issue Oct 4, 2017 · 4 comments
Closed

Countdown window sticks around after execution #4

Luke-Baker opened this issue Oct 4, 2017 · 4 comments

Comments

@Luke-Baker
Copy link

Windows 10 x64
Firefox 58.0a1, build 20171003220138
Auto Shutdown 0.1.1

I ran a custom command and the countdown window stuck around showing 00 afterwards. It would be nice if it closed once the command has been executed successfully.

@andy-portmen
Copy link
Owner

There is a new option in 0.1.2 to allow closing of the countdown window if the external command execution is successful (return code is 0).

@Luke-Baker
Copy link
Author

I'm afraid I couldn't get the option to work. Based on the Browser Console, it would seem Firefox doesn't think the add-on should be allowed to close the window:

GET https://upload.wikimedia.org/wikipedia/commons/thumb/4/4c/Bluebonnet-8100.jpg/375px-Bluebonnet-8100.jpg [HTTP/2.0 200 OK 0ms]
TypeError: invalid 'in' operand browser[Learn More]  tabbrowser.xml:2431:1
NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIMessageSender.sendAsyncMessage]  ext-windows.js:19
Scripts may not close windows that were not opened by script.  index.js:27:4

Firefox 58.0a1 build 20171004220309
Auto Shutdown 0.1.2

andy-portmen added a commit that referenced this issue Oct 5, 2017
@andy-portmen
Copy link
Owner

Okay I checked it in Chrome and it worked! 0.1.3 is working in FF too. Thanks for the report.

@Luke-Baker
Copy link
Author

Thank you. I've verified that it works.

Firefox 58.0a1 build 20171005220204
Auto Shutdown 0.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants