You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hey andy, good job on your backend routes, some comments for revision:
Backend Routes
Contains the following sections: HTML, API Endpoints(Backend)
Each route has a description
API Endpoint routes contains wildcard variables written in snake_case
Routes does not contain superfluous routes
Have API routes that will allow the front end to get all info it needs and does not have unneeded routes:
i.e. probably don't need a GET likes api endpoint because that info comes through the post show
Comments
users: "GET /api/stocks/:stock_id/users returns list of users that are watching a particular stock": you should just be able to use your GET /api/users/:id to retrieve stocks being watched by a user via associations, so this route is unnecessary
users: GET /api/users/search not sure how you're searching for people in robinhood? don't think this is necessary
stocks: "GET /api/stocks - used" missing detail on what you plan on doing with this route
stocks: POST /api/stocks, PATCH /api/stocks/:id, DELETE /api/stocks/:id - don't think users should have the ability to create, edit, or delete a stock, not part of your stocks MVP, stocks should be pre-seeded
stocks: GET /api/stocks/search if you're using a query string, make sure you look up how to add that information correctly and grab it from the backend (probably need to dynamically add the search parameters when making the ajax request using a '?', and then accessing the params in the controller)
watchlists: don't need a separate route for grabbing a user's watchlist, can be done when grabbing the user via associations
missing routes for handling when a user buys a stock, sells a stock, buys more of the same stock (edit) etc.
The text was updated successfully, but these errors were encountered:
hey andy, good job on your backend routes, some comments for revision:
Backend Routes
snake_case
GET likes
api endpoint because that info comes through the post show
Comments
GET /api/users/search
not sure how you're searching for people in robinhood? don't think this is necessaryPOST /api/stocks
,PATCH /api/stocks/:id
,DELETE /api/stocks/:id
- don't think users should have the ability to create, edit, or delete a stock, not part of your stocks MVP, stocks should be pre-seededGET /api/stocks/search
if you're using a query string, make sure you look up how to add that information correctly and grab it from the backend (probably need to dynamically add the search parameters when making the ajax request using a '?', and then accessing the params in the controller)The text was updated successfully, but these errors were encountered: