Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve: Remove extra styles, Add vars for units #51

Closed
wants to merge 1 commit into from
Closed

Improve: Remove extra styles, Add vars for units #51

wants to merge 1 commit into from

Conversation

tpkahlon
Copy link

  • Declaration of units in Vars for more control in future iterations
  • Remove unwanted style tags in current iteration to tone down CSS
  • Split display attribute in its own context for easier declaration on tags across site

@andybrewer
Copy link
Owner

Thanks for your contribution. While I'm sure some folks might appreciate this approach, I'm going to stick with hard coded values right now. They can easily be overwritten by custom CSS and keep the library easy to learn.

@andybrewer andybrewer closed this Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants