Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small think-o in scales delivered to the vectorizer #19

Closed
davidwhogg opened this issue Dec 15, 2015 · 1 comment
Closed

small think-o in scales delivered to the vectorizer #19

davidwhogg opened this issue Dec 15, 2015 · 1 comment
Labels
bug code highest current priority

Comments

@davidwhogg
Copy link
Collaborator

We should offset using a label offset to a fiducial label value (as we do).

But we should scale the K + K * (K + 1) / 2 vectorizer-output terms independently.

Ask @davidwhogg for details.
andycasey added a commit that referenced this issue Dec 18, 2015
@andycasey
Allow custom scale factors to be given to the vectorizer #19
6a559ec
andycasey added a commit that referenced this issue Dec 18, 2015
@andycasey
Relevant to #19
e48ecc1
@davidwhogg
Copy link
Collaborator Author

This issue is now addressed, in that we are using validation to set the scaling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug code highest current priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidwhogg