This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
adding base formats for date and time to complement the custom available formats #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andyearnshaw this seems to be the key. It works locally for me. Please, do a quick review, and we can release rc-3. |
…ble formats per calendar
|
Tests are now passing locally. I have also confirmed that we are adding 8 new format patterns (4 dateFormats, 4 timeFormats) when the polyfill process the data in the client, I think we are good here. |
andyearnshaw
added a commit
that referenced
this pull request
Jun 19, 2015
adding base formats for date and time to complement the custom available formats
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #107
This PR will expand the metadata to use timeFormats, and dateFormats from CLDR as a way to provide basic formatting capabilities instead of only relying on custom available formats. This should now matches what browsers are supporting.
Note: the huge diff that you see is because another PR that fixes the narrow value for calendars, which was never released in rc-1 or rc-2