This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Replace for-in with basic for loop in FormatNumber #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watilde
force-pushed
the
patch/fix-FormatNumber
branch
from
09155a2
to
8b00448
Compare
|
I wonder how is that this wasn't catch by our tests. I will merge and release the patch soon. |
|
there were few more places where the same problem occur, here is the patch: 6057ef3 |
|
Oh good catch. Thanks! |
|
released as intl@1.2.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #176.
Basically
for-inloop iterate over all enumerable properties of the object itself and those the object inherits from its constructor's prototype. In the FormatNumber function, the parts Object is from List and that can be parent Object. To fix it, I think we should add ahasOwnPropertycheck intofor-inloop or use this simple way.