Make _account_id optional in AccountInfo #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AccountInfo struct is used in other structs, such as ApprovalInfo, and _account_id may not always be set in those cases. In these cases if the _account_id field is not setup with 'omitempty' then the field will be included anyway even if Gerrit does not return it. Thanks to @perolausson for finding and explaining the issue.
|
@perolausson would you mind taking a look? I think this addresses what you brought up in #16 but I wanted to be sure before it's merged. |
|
I'll try it out later this evening! On 12 Oct 2016 16:36, "opalmer" notifications@github.com wrote:
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #16.