Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider upgrading version of jwt-go to fix security vulnerability #343

Closed
lodi-g opened this issue Feb 8, 2021 · 8 comments · Fixed by #387
Closed

Consider upgrading version of jwt-go to fix security vulnerability #343

lodi-g opened this issue Feb 8, 2021 · 8 comments · Fixed by #387

Comments

@lodi-g
Copy link

lodi-g commented Feb 8, 2021

Hi,

The dependency jwt-go has a security vulnerability in all versions <4.0.0: dgrijalva/jwt-go#428 .
Please consider upgrading to the latest version (v4.0.0-preview1) or switching for another library.

Thanks!

@github-actions
Copy link

github-actions bot commented Feb 8, 2021

Hi! Thank you for taking the time to create your first issue! Really cool to see you here for the first time. Please give us a bit of time to review it.

@benjivesterby
Copy link
Collaborator

@andygrunwald @ghostsquad Perhaps we should set up dependabot so that it can auto-pr package upgrades and merge if the CI passes?

@andygrunwald
Copy link
Owner

Screen Shot 2021-02-08 at 16 24 16

Everything is activated already. Is there anything else to do from our side?

Is there a way to check if this vuln is already caught up by the bot?

@benjivesterby
Copy link
Collaborator

Hmm I'm not sure. Do you have it setup here? https://app.dependabot.com/accounts/andygrunwald

@andygrunwald
Copy link
Owner

Thanks @benjivesterby
Dependabot is now working. PRs are incoming. Until now, no one for go-jwt.
Maybe we wait a bit and/or do it by hand :)

@benjivesterby
Copy link
Collaborator

@andygrunwald no problem. I would suspect that it will auto-PR it. When I've had a security vuln pop on my libs before it took a couple days before dependabot updated. If not that we can keep an eye and do it manually.

@lodi-g
Copy link
Author

lodi-g commented Feb 8, 2021

Thank you for your reactivity!
Please keep in mind that the newest version of jwt-go is a "preview" version so it might not be publised at the "latest" but more in a beta form, we should make sure it does not break anything before upgrading.

@yarlson
Copy link
Contributor

yarlson commented Jul 19, 2021

@andygrunwald https://github.com/dgrijalva/jwt-go has been abondoned (see dgrijalva/jwt-go#462). In order to fix the vulnarability we have to switch to a community driven fork https://github.com/golang-jwt/jwt . The issue has been fixed in golang-jwt/jwt#12

yarlson added a commit to yarlson/go-jira that referenced this issue Jul 19, 2021
andygrunwald#343

 https://github.com/dgrijalva/jwt-go has been abondoned (see dgrijalva/jwt-go#462). In order to fix the vulnarability we have to switch to a community driven fork https://github.com/golang-jwt/jwt . The issue has been fixed in golang-jwt/jwt#12
yarlson added a commit to yarlson/go-jira that referenced this issue Jul 19, 2021
andygrunwald#343

 https://github.com/dgrijalva/jwt-go has been abondoned (see dgrijalva/jwt-go#462). In order to fix the vulnarability we have to switch to a community driven fork https://github.com/golang-jwt/jwt . The issue has been fixed in golang-jwt/jwt#12
lwsanty pushed a commit to lwsanty/go-jira that referenced this issue Aug 18, 2021
andygrunwald#343

 https://github.com/dgrijalva/jwt-go has been abondoned (see dgrijalva/jwt-go#462). In order to fix the vulnarability we have to switch to a community driven fork https://github.com/golang-jwt/jwt . The issue has been fixed in golang-jwt/jwt#12

(cherry picked from commit fff481a)
lwsanty added a commit to lwsanty/go-jira that referenced this issue Aug 18, 2021
andygrunwald#343

 https://github.com/dgrijalva/jwt-go has been abondoned (see dgrijalva/jwt-go#462). In order to fix the vulnarability we have to switch to a community driven fork https://github.com/golang-jwt/jwt . The issue has been fixed in golang-jwt/jwt#12

(cherry picked from commit fff481a)

Co-authored-by: Yar Krvtsov <yarlson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants