Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servicedesk Get/Add Organizations - serviceDeskID should allow string type #418

Open
james-cast opened this issue Nov 16, 2021 · 2 comments
Labels
needs triage Ticket that needs triage (a proper look for classification)

Comments

@james-cast
Copy link
Contributor

james-cast commented Nov 16, 2021

Is your feature request related to a problem? Please describe.

In the documentation, it states that the serviceDeskID provided should be an integer.

serviceDeskId REQUIRED
integer
The ID of the service desk from which the organization list will be returned. This can alternatively be a project identifier.

https://developer.atlassian.com/cloud/jira/service-desk/rest/api-group-organization/#api-rest-servicedeskapi-servicedesk-servicedeskid-organization-get

However, this is not 100% correct it can also be a project identifier (a string) as described here: https://developer.atlassian.com/cloud/jira/service-desk/rest/intro/#project-identifiers

Describe the solution you'd like

Update servicedesk.go signatures to allow strings instead of only int type for serviceDeskID.

@github-actions
Copy link

Hi! Thank you for taking the time to create your first issue! Really cool to see you here for the first time. Please give us a bit of time to review it.

@james-cast james-cast changed the title Servicedesk Get/Add Organizations - serviceDeskID should be string type Servicedesk Get/Add Organizations - serviceDeskID should allow string type Nov 16, 2021
james-cast added a commit to james-cast/go-jira that referenced this issue Nov 19, 2021
see the issue for details on the reason for change

closes issue andygrunwald#418
@andygrunwald andygrunwald added the needs triage Ticket that needs triage (a proper look for classification) label Aug 20, 2022
@andygrunwald
Copy link
Owner

Hey,

I am very sorry that this issue has been open for a long time with no final solution. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma.

However, there is news: We are kicking off v2 of this library 🚀

To provide visibility, we created the Road to v2 Milestone and calling for your feedback in #489

The development will take some time; however, I hope you can benefit from the changes.
If you seek priority development for your issue + you like to sponsor it, please contact me.

What does this mean for my issue?

We will work on this issue indirectly.
This means that during the development phase, we aim to tackle it.
Maybe in a different way like it is currently handled.
Please understand that this will take a while because we are running this in our spare time.

Final words

Thanks for using this library.
If there is anything else you would like to tell us, let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Ticket that needs triage (a proper look for classification)
Projects
None yet
Development

No branches or pull requests

2 participants