Tempo Timesheets woklogs #133
Conversation
README.md
Outdated
| @@ -206,7 +206,7 @@ func main() { | |||
| AuthURL: fmt.Sprintf("%s/rest/auth/1/session", base), | |||
| } | |||
|
|
|||
| jiraClient, err := jira.NewClient(tp.Client(), base) | |||
| jiraClient, _ := jira.NewClient(tp.Client(), base) | |||
There was a problem hiding this comment.
You dropped err, because it is not used in the example, right?
If yes, i would go for an additional
if err != nil {
panic(err)
}here, because it is an example and is really often used as a copy / paste go to start code.
With the additional panic, people might start think about error handling.
jira.go
Outdated
| @@ -231,6 +234,10 @@ func (c *Client) Do(req *http.Request, v interface{}) (*Response, error) { | |||
| // Open a NewDecoder and defer closing the reader only if there is a provided interface to decode to | |||
| defer httpResp.Body.Close() | |||
| err = json.NewDecoder(httpResp.Body).Decode(v) | |||
|
|
|||
| if err != nil { | |||
| log.Printf("error JSON encoding body: %v", httpResp.Body) | |||
There was a problem hiding this comment.
This leads to a side effect and is not necessary, because a couple of lines after in https://github.com/andygrunwald/go-jira/blob/master/jira.go#L246 the err is returned.
I would vote for a removal. Or is there any special reason for it?
There was a problem hiding this comment.
Very often I can't understand what kind of error jira thrown when I ask for some data. Logging the answer helped to investigate it. I think that this debugging approach will be helpful for others in interacting with jira.
jira.go
Outdated
| @@ -12,6 +12,7 @@ import ( | |||
|
|
|||
| "github.com/google/go-querystring/query" | |||
| "github.com/pkg/errors" | |||
| "log" | |||
There was a problem hiding this comment.
See my comment below at log.Printf...
| ) | ||
|
|
||
| const TTWorklogTimeFormat = "2006-01-02T15:04:05.000" | ||
| const TTWorklogDateFormat = "2006-01-02" |
There was a problem hiding this comment.
Can you add comments here? With a link to the docs as well?
There was a problem hiding this comment.
WorklogBean that returns worklog api uses this time format. Watch the Returns section: http://developer.tempo.io/doc/timesheets/api/rest/latest/#848933329
worklog.go
Outdated
| const TTWorklogTimeFormat = "2006-01-02T15:04:05.000" | ||
| const TTWorklogDateFormat = "2006-01-02" | ||
|
|
||
| // SprintService handles sprints in JIRA Agile API. |
There was a problem hiding this comment.
This seems to be a copy / paste doc
There was a problem hiding this comment.
Yep. Sorry. I'll clean it up.
@andygrunwald suggest please how to add readme about this functional. Because it is a JIRA plugin api request, I think that it must be some kind of "additional possibilities" section. What do you think? |
|
@rbriski What do you think about the implementation of this JIRA API Request here? |
There was a problem hiding this comment.
I'm appreciative of the work here but I don't think we should add plugins into the core library. It leads to confusion when those services don't work for everyone.
I would, however, like to talk about how to import plugins so you could write it in your own repo and then import the library along with go-jira and add the service.
I've opened an issue at #135 to do this. In the meantime, if this is time sensitive, just use your fork. However, if you have time @smgladkovskiy , I'd love to get your help figuring out how to handle plugins in a more extensible way.
| @@ -32,7 +32,7 @@ func NewJiraError(resp *Response, httpError error) error { | |||
| jerr := Error{HTTPError: httpError} | |||
| err = json.Unmarshal(body, &jerr) | |||
| if err != nil { | |||
| httpError = errors.Wrap(errors.New("Could not parse JSON"), httpError.Error()) | |||
| httpError = errors.Wrap(errors.New(fmt.Sprintf("Could not parse JSON from body %s", string(body))), httpError.Error()) | |||
There was a problem hiding this comment.
If you're going to do this just remove errors.New and use fmt.Errorf
…et-woklogs # Conflicts: # README.md # jira.go
Hi!
In my work I need to collect users worklogs. Native Jira methods did not give this information in clean and easy way. But there is a Tempo Timesheets plugin which has an API method to collect worklogs by username and dates.
I implemented method to get worklogs. Here it is.