Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user.go #439

Merged
merged 4 commits into from
Feb 20, 2022
Merged

Update user.go #439

merged 4 commits into from
Feb 20, 2022

Conversation

metalbreeze
Copy link
Contributor

@metalbreeze metalbreeze commented Feb 16, 2022

Description

According https://developer.atlassian.com/cloud/jira/platform/rest/v2/api-group-user-search/#api-rest-api-2-user-search-get
add those username/accountId/property parameters to this find method

Information that is useful here:

  • The What: add some paramater method to support find method
  • The Why: Without this, The username query parameter was not provided error msg will be return
  • Type of change: add missing paramater support
  • Breaking change:Backward compatible
  • Related to an issue: N/A
  • Jira Version + Type: Jira v8.13.9

Example:

jiraClient.User.Find("",jira.WithUsername("xxx@xxx.com"))

Checklist

Copy link
Collaborator

@benjivesterby benjivesterby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these are failing linter checks. Please go fmt the file and push the changes

@metalbreeze
Copy link
Contributor Author

done by go fomat file

@metalbreeze
Copy link
Contributor Author

fix some compile error by re-compile it .

@metalbreeze
Copy link
Contributor Author

wow. great. finally.

@benjivesterby benjivesterby merged commit 629c2d7 into andygrunwald:master Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants