Add the func of getting system and metrics snapshot by pid

[douzl]

Signed-off-by: Zhongqiang Dou douzl0814@163.com

[coveralls]

Coverage increased (+1.4%) to 80.0% when pulling b712c2d on douzl:snapshot into 7f39301 on andygrunwald:master.

[coveralls]

Coverage increased (+1.4%) to 80.0% when pulling b712c2d on douzl:snapshot into 7f39301 on andygrunwald:master.

[andygrunwald]

Thank you for this.
Right now i am on vacation and i will be back in ~9 days. Then i will have
a look.
Just to let you know :)

Am Samstag, 10. September 2016 schrieb Coveralls :

[image: Coverage Status] https://coveralls.io/builds/7827853

Coverage increased (+1.4%) to 80.0% when pulling b712c2d
b712c2d
on douzl:snapshot into 7f39301
7f39301
on andygrunwald:master.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#10 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATiQIULIvt-UNDNTmlbS71-tv_NgD7Yks5qolOAgaJpZM4J5p1b
.

[coveralls]

Coverage increased (+3.1%) to 81.752% when pulling 863307a on douzl:snapshot into 7f39301 on andygrunwald:master.

[coveralls]

Coverage increased (+3.1%) to 81.752% when pulling 863307a on douzl:snapshot into 7f39301 on andygrunwald:master.

[coveralls]

Coverage increased (+3.1%) to 81.752% when pulling 863307a on douzl:snapshot into 7f39301 on andygrunwald:master.

[andygrunwald]

Would it make sense to add a new struct for the snapshot endpoint like you did for System?
With this we get rid of the interface{} and the necessary casting afterwards.
You applied the dummy json already in tests/master1.metrics.snapshot.json

[douzl]

The fields are too much. I will handle it later. :)

[andygrunwald]

Thank you @douzl.
It looks fine :) I made a comment related to the map[string]interface{}.

[coveralls]

Coverage increased (+3.4%) to 82.014% when pulling 3ea167d on douzl:snapshot into 13a9540 on andygrunwald:master.

[douzl]

@andygrunwald Updated with the struct MetricsSnapshot in type.go， please help to review. Thanks!

[andygrunwald]

Looks good, thank you @douzl!