fix(no-nested-object-setvalue): only throw error for Array & Object e…

…xpressions As title. Close #17
andykao1213 · Mar 26, 2022 · e5b342b · e5b342b
1 parent 5e26c7e
commit e5b342b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/rules/no-nested-object-setvalue.js b/lib/rules/no-nested-object-setvalue.js
@@ -59,7 +59,12 @@ module.exports = {
             const { parent: setValueCallExpression } =
               setValueReference.identifier;
             const secondArgument = setValueCallExpression.arguments[1];
-            if (secondArgument && secondArgument.type !== "Literal") {
+            if (
+              secondArgument &&
+              ["ArrayExpression", "ObjectExpression"].includes(
+                secondArgument.type
+              )
+            ) {
               return context.report({
                 node: secondArgument,
                 messageId: "noNestedObj",

diff --git a/tests/lib/rules/no-nested-object-setvalue.js b/tests/lib/rules/no-nested-object-setvalue.js
@@ -38,6 +38,20 @@ ruleTester.run("no-nested-object-setvalue", rule, {
         setValue('yourDetails', { firstName: 'value' });
       `,
     },
+    {
+      code: normalizeIndent`
+        const {setValue} = useForm();
+        const myFunc = () => 10
+        setValue('yourDetails', myFunc);
+      `,
+    },
+    {
+      code: normalizeIndent`
+        const {setValue} = useForm();
+        const myVar = 10
+        setValue('yourDetails', myVar);
+      `,
+    },
     {
       code: normalizeIndent`
         function Component() {