Skip to content

Commit

Permalink
proxy: add reshard handle radondb#436
Browse files Browse the repository at this point in the history
[summary]

Syntax:
RADON RESHARD tbl_name TO new_tbl_name

You can use RADON RESHARD to shift data from one SINGLE table
to another PARTITION table, the cmd execute the shift cmd and
will return immediately, the shift will run in background on
other goroutine.

NOTICE: the SINGLE table with the primary key can be partitioned.

TODO: the shift progress bar will call other interface

[test case]

src/proxy/admin_reshard_test.go
src/proxy/admin_shift_test.go
src/router/frm_test.go

[patch codecov]
src/proxy/admin_reshard.go: 98.4%
src/proxy/admin_shift.go: 81.8%
src/router/frm.go: 100%
  • Loading branch information
andyli029 committed Sep 4, 2019
1 parent b7aa530 commit a11411f
Show file tree
Hide file tree
Showing 10 changed files with 696 additions and 6 deletions.
182 changes: 182 additions & 0 deletions src/proxy/admin_reshard.go
@@ -0,0 +1,182 @@
/*
* Radon
*
* Copyright 2018-2019 The Radon Authors.
* Code is licensed under the GPLv3.
*
*/

package proxy

import (
"errors"
"fmt"
"sync"
"time"

"backend"
"router"

"github.com/xelabs/go-mysqlstack/sqlparser/depends/sqltypes"
"github.com/xelabs/go-mysqlstack/xlog"
)

const (
shiftUnfinished = 0
shiftFinished = 1
)

type Reshard struct {
mu sync.RWMutex
wg sync.WaitGroup
log *xlog.Log
scatter *backend.Scatter
router *router.Router
spanner *Spanner
user string
db string
singleTable string
dstDB string
reshardTable string
tmpReshardTable string
ticker *time.Ticker
handle ReshardHandle
shiftProcessBar int
shiftStatus error
}

var _ ReshardHandle = &Reshard{}

type ReshardHandle interface {
ShiftProcess() error
}

func (reshard *Reshard) ShiftProcess() error {
return shiftTableLow(reshard.db, reshard.singleTable, reshard.dstDB, reshard.reshardTable, reshard.user, reshard.spanner)
}

func (reshard *Reshard) ShiftProcessBar() int {
reshard.mu.RLock()
defer reshard.mu.RUnlock()
return reshard.shiftProcessBar
}

func (reshard *Reshard) SetShiftProcessBar(finished int) {
reshard.mu.Lock()
defer reshard.mu.Unlock()
reshard.shiftProcessBar = finished
}

func (reshard *Reshard) ShiftStatus() error {
reshard.mu.RLock()
defer reshard.mu.RUnlock()
return reshard.shiftStatus
}

func (reshard *Reshard) SetShiftStatus(err error) {
reshard.mu.Lock()
defer reshard.mu.Unlock()
reshard.shiftStatus = err
}

func NewReshard(log *xlog.Log, scatter *backend.Scatter, router *router.Router,
spanner *Spanner, user string) *Reshard {
return &Reshard{
log: log,
scatter: scatter,
router: router,
spanner: spanner,
ticker: time.NewTicker(time.Duration(time.Second * 5)),
user: user,
}
}

func (reshard *Reshard) SetHandle(r ReshardHandle) {
reshard.handle = r
}

func (reshard *Reshard) CheckReshardDBTable(db, singleTable, dstDB, dstTable string) (bool, error) {
isSingle, err := reshard.IsSingleTable(db, singleTable)
if err != nil {
err := fmt.Errorf("reshard.check.[%s].is.singleTable.err.%v", singleTable, err)
return false, err
}

if isSingle != true {
err := fmt.Errorf("reshard.check.[%s].is.not.singleTable", singleTable)
return false, err
}

err = reshard.router.CheckDatabase(dstDB)
if err != nil {
err := fmt.Errorf("reshard.check.[%s].is.not.exist", dstDB)
return false, err
}

// make sure the dstTable is not exist to the shift.
isExist, err := reshard.router.CheckTable(dstDB, dstTable)
if err == nil && isExist == false {
return true, nil
}

if err == nil {
err = fmt.Errorf("reshard.check.[%s].is.exist", dstTable)
}
return false, err
}

func (reshard *Reshard) IsSingleTable(db, singleTable string) (bool, error) {
table, err := reshard.router.TableConfig(db, singleTable)
if err != nil {
return false, err
}

if table.ShardType == "SINGLE" {
return true, nil
}
return false, nil
}

// ReShardTable just reshard single table to the sharding table now.
func (reshard *Reshard) ReShardTable(db, singleTable, dstDB, dstTable string) (*sqltypes.Result, error) {
log := reshard.log
qr := &sqltypes.Result{}

if ok, err := reshard.CheckReshardDBTable(db, singleTable, dstDB, dstTable); ok != true {
log.Error("reshard.check[%s.%s->%s.%s].is.not.ok:%v.", db, singleTable, dstDB, dstTable, err)
err := fmt.Sprintf("reshard.check[%s.%s->%s.%s].is.not.ok:%v.", db, singleTable, dstDB, dstTable, err)
return qr, errors.New(err)
}
reshard.db = db
reshard.singleTable = singleTable
reshard.dstDB = dstDB
reshard.reshardTable = dstTable

// start the shift process.
reshard.shiftTable(reshard.user)
return qr, nil
}

// The call is returned immediately, won't call wg.Wait()
// 1. the shift status will be filled by rc when finished
// 2. the shift progress bar will call other interface.
func (reshard *Reshard) shiftTable(user string) error {
var wg sync.WaitGroup

oneshift := func(db, srcTable, dstDB, dstTable string, user string, spanner *Spanner) {
defer wg.Done()

err := reshard.handle.ShiftProcess()
reshard.SetShiftProcessBar(shiftFinished)
if err != nil {
reshard.SetShiftStatus(err)
return
}

reshard.SetShiftStatus(nil)
}

wg.Add(1)
go oneshift(reshard.db, reshard.singleTable, reshard.dstDB, reshard.reshardTable, user, reshard.spanner)
return nil
}

0 comments on commit a11411f

Please sign in to comment.