Skip to content

Commit

Permalink
*: enable ppc64le bootimage support
Browse files Browse the repository at this point in the history
  • Loading branch information
Prashanth684 committed Mar 18, 2020
1 parent 84608d9 commit d27e3d7
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
2 changes: 2 additions & 0 deletions pkg/types/machinepools.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ const (
ArchitectureAMD64 = "amd64"
// ArchitectureS390X indicates s390x (IBM System Z).
ArchitectureS390X = "s390x"
// ArchitecturePPC64LE indicates ppc64 little endian (Power PC)
ArchitecturePPC64LE = "ppc64le"
)

// MachinePool is a pool of machines to be installed.
Expand Down
9 changes: 9 additions & 0 deletions pkg/types/validation/installconfig_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -893,6 +893,15 @@ func TestValidateInstallConfig(t *testing.T) {
}(),
expectedError: `^compute\[0\].architecture: Invalid value: "s390x": heteregeneous multi-arch is not supported; compute pool architecture must match control plane$`,
},
{
name: "cluster is not heteregenous",
installConfig: func() *types.InstallConfig {
c := validInstallConfig()
c.Compute[0].Architecture = types.ArchitecturePPC64LE
return c
}(),
expectedError: `^compute\[0\].architecture: Invalid value: "ppc64le": heteregeneous multi-arch is not supported; compute pool architecture must match control plane$`,
},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
Expand Down
5 changes: 3 additions & 2 deletions pkg/types/validation/machinepools.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,9 @@ var (
}()

validArchitectures = map[types.Architecture]bool{
types.ArchitectureAMD64: true,
types.ArchitectureS390X: true,
types.ArchitectureAMD64: true,
types.ArchitectureS390X: true,
types.ArchitecturePPC64LE: true,
}

validArchitectureValues = func() []string {
Expand Down

0 comments on commit d27e3d7

Please sign in to comment.