Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for GRAPH.CONSTRAINT #2536

Closed
wants to merge 7 commits into from
Closed

Conversation

OfirMos
Copy link
Contributor

@OfirMos OfirMos commented Jan 2, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023

Codecov Report

Base: 92.23% // Head: 92.21% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (b9dce18) compared to base (f10c81a).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2536      +/-   ##
==========================================
- Coverage   92.23%   92.21%   -0.02%     
==========================================
  Files         113      113              
  Lines       29380    29384       +4     
==========================================
- Hits        27098    27096       -2     
- Misses       2282     2288       +6     
Impacted Files Coverage Δ
redis/commands/graph/commands.py 84.55% <50.00%> (-1.17%) ⬇️
tests/test_cluster.py 96.90% <0.00%> (-0.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash marked this pull request as draft January 2, 2023 13:50
@OfirMos OfirMos marked this pull request as ready for review January 3, 2023 07:59
props: List[str]):
"""
Constraint operation,
For more information see `GRAPH.CONSTRAINT <https://redis.io/commands/graph.constraint>`_. # noqa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can I see the graph.constraint docs that are proposed? it's a dead link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't be when we merge it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OfirMos did this happne, or can we close off the PR? I don't see it merged or available currently.

@OfirMos OfirMos force-pushed the constraint branch 2 times, most recently from 80e1fa0 to 8988448 Compare January 3, 2023 09:13
@OfirMos OfirMos marked this pull request as draft February 28, 2023 14:58
@chayim chayim closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants