allow nil listener

andyollylarkin · Aug 25, 2023 · 05866be · 05866be
1 parent 5706cb6
commit 05866be
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/subscriber.go b/subscriber.go
@@ -146,7 +146,7 @@ func (s *Subscriber) GetConnection() (Connection, error) {
 
 // Connect establish connection.
 func (s *Subscriber) Connect(l Listener) error {
-	if l == nil {
+	if l == nil && s.conn == nil {
 		return fmt.Errorf("listener cant be nil")
 	}
 

diff --git a/subscriber_test.go b/subscriber_test.go
@@ -292,6 +292,18 @@ func TestSubscriberConnectionNotSetError(t *testing.T) {
 	}
 }
 
+func TestAllowNilListenerWhenConnectionSet(t *testing.T) {
+	pc := NewPipeConnection()
+	s, err := watermillnet.NewSubscriber(watermillnet.SubscriberConfig{
+		Marshaler:   pkg.MessagePackMarshaler{},
+		Unmarshaler: pkg.MessagePackUnmarshaler{},
+	})
+	require.NoError(t, err)
+	s.SetConnection(pc)
+	err = s.Connect(nil)
+	require.NoError(t, err)
+}
+
 // Subscribe topic independent
 
 // Susccribe receive multi message