Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename project #10

Closed
cmckni3 opened this issue Jul 9, 2017 · 9 comments
Closed

Rename project #10

cmckni3 opened this issue Jul 9, 2017 · 9 comments

Comments

@cmckni3
Copy link
Collaborator

cmckni3 commented Jul 9, 2017

Would you be open to renaming the project to ngx-super-table?

See https://juristr.com/blog/2016/12/let-me-explain-angular-release-cycles/ about the release cycles and how everything will be simply called Angular instead of Angular 2 or Angular 4. Some other projects taken the approach of saying Angular X instead of Angular 2+, Angular 4, etc.

@cmckni3
Copy link
Collaborator Author

cmckni3 commented Jul 9, 2017

Should probably rename after rolling out the fixes for the library to work in 2.4.

Repository owner deleted a comment from andy-because Jul 10, 2017
@andyperlitch
Copy link
Owner

Excellent suggestion, Chris! The whole differentiation between angular and angularJS is such a headache... I like the ngx- prefix convention. I'll review your PR tonight/tomorrow, then after we merge it, let's tackle this.

@cmckni3
Copy link
Collaborator Author

cmckni3 commented Jul 10, 2017

Yeah, it makes Google searches impossible haha. I am glad Joe Eames et al. created ngDoc.

@andyperlitch
Copy link
Owner

oOo this is a new site for me... thanks!

@andyperlitch
Copy link
Owner

Hey @cmckni3,

I have renamed all necessary files and successfully ran the demo. I have also added you as a collaborator.

I am having some difficulty running npm run release. I'll open a new issue with publishing.

@cmckni3
Copy link
Collaborator Author

cmckni3 commented Jul 11, 2017

Thanks!

Oops, I forgot to update the build "npm" script. I copied over the angular/cli build script instead haha.

@cmckni3
Copy link
Collaborator Author

cmckni3 commented Jul 11, 2017

Are you on Windows @andyperlitch? I'm not sure those scripts will work unless you use Ubuntu on Windows.

@andyperlitch
Copy link
Owner

nope, i am on mac

@cmckni3
Copy link
Collaborator Author

cmckni3 commented Jul 11, 2017

Should work on Linux and Mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants