Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename project to d3-ngx-service? #74

Open
andyperlitch opened this issue Jul 10, 2017 · 8 comments
Open

Rename project to d3-ngx-service? #74

andyperlitch opened this issue Jul 10, 2017 · 8 comments
Assignees

Comments

@andyperlitch
Copy link

Hi there! Love the project. I am opening this merely because someone opened an equivalent issue on my library and I think it seems like a reasonable change that i hope may catch on.

Anyway, if you disagree or do not want to deal with the headache of a rename I completely understand and please feel free to close this issue.

Regards,
Andy

@tomwanzek
Copy link
Owner

@andyperlitch Thanks for the ping, I am actively considering it. I was tempted to make the change-over with the next major release I was considering. I had hoped that a more standard third-party library cli (similar to angular/cli) is converged on sooner. Seems we are still not there yet, despite a number of 3rd part lib generators.

So I might mull this change independently, despite the headache changing the naming across github and npm (and the related demo app). 😄

@tomwanzek tomwanzek self-assigned this Jul 15, 2017
@andyperlitch
Copy link
Author

andyperlitch commented Jul 28, 2017

@tomwanzek i know this is unrelated to this issue (feel free to delete) but im not quite sure how else to contact you... I posted this question on stackoverflow with no responses yet. Checked the GH contributors of @types/d3 and lo and behold! If you get a chance, I could use some help.

Cheers!

@tomwanzek
Copy link
Owner

@andyperlitch I will look at the question on SO and respond there, if I find an issue with the definitions of the underlying D3 modules, then I will open it in the DefinitelyTyped repo and @-mention you there. Cheers.

@tomwanzek
Copy link
Owner

@andyperlitch I posted a suggested answer on SO.

@Stradivario
Copy link

Does anyone know what is the meaning of ngx ?

It means Angular Reactive Extension

means that at least there should be one single method which returns Observable :)

@tomwanzek
Copy link
Owner

@Stradivario the ask is to use ngx for Angular version "x" rather than the historic root of this service in Angular 2 (ng2). As for your observable comment, no-one is asking for "rx" here 😄

@Stradivario
Copy link

I am a bit stupid :D i am really sorry just disregard my comment i dont belong here :D

@tomwanzek
Copy link
Owner

No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants