Add nested forms with nested arrays support #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezhny
force-pushed
the
add-nested-forms-with-nested-arrays-support
branch
from
4f1c273
to
9944a40
Compare
epoberezhny
force-pushed
the
add-nested-forms-with-nested-arrays-support
branch
from
9944a40
to
9906341
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @andypike!
I have nested form in my app. A model has a
has_onerelationship that has ahas_manyrelationship butRectify::Form.from_paramsmethod does not support this case out of the box. I added support for this case.Note: I fixed travis config to avoid this problem with ruby 2.5.1 https://bundler.io/blog/2019/05/14/solutions-for-cant-find-gem-bundler-with-executable-bundle.html