Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setFieldState call to useField on validation change #278

Merged
merged 5 commits into from
Jul 30, 2020

Conversation

andyrichardson
Copy link
Owner

@andyrichardson andyrichardson commented Jul 20, 2020

About

Fix #235

Notes

  • Need to confirm whether reducer will rerender on object equality (hopefully not the case) We good

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020

Codecov Report

Merging #278 into master will decrease coverage by 0.95%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
- Coverage   91.51%   90.55%   -0.96%     
==========================================
  Files           3        3              
  Lines         165      180      +15     
  Branches       56       62       +6     
==========================================
+ Hits          151      163      +12     
- Misses         11       14       +3     
  Partials        3        3              
Impacted Files Coverage Δ
src/useField.ts 91.11% <75.00%> (-6.04%) ⬇️
src/useForm.ts 90.07% <88.88%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf7779...8610486. Read the comment docs.

@andyrichardson andyrichardson merged commit 846a4a9 into master Jul 30, 2020
@andyrichardson andyrichardson deleted the 235-update-validation branch July 30, 2020 09:50
@andyrichardson
Copy link
Owner Author

Shoutout to @JoviDeCroock for feedback on this ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to validation arg doesn't update validation function
2 participants