Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run ci on pull requests too #12

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

reconbot
Copy link
Contributor

Normal push events don't run from external repositories but pr events should. Added benefit that it runs on a merge commit to master.

Normal push events don't run from external repositories but pr events should.
Copy link
Owner

@andyrichardson andyrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@andyrichardson andyrichardson merged commit b483185 into andyrichardson:master Jul 6, 2021
andyrichardson pushed a commit that referenced this pull request Jul 12, 2021
Normal push events don't run from external repositories but pr events should.
andyrichardson added a commit that referenced this pull request Jul 14, 2021
* Add ping/pong handlers

* Add step function boilerplate for ping/pong

* State machine invocation (broken ARN but execution working)

* Working with pong handling

* Add configurable ping/pong durations

* Update README

* Update serverless config + naming of machine

* fix: wrong id sent on "next" messages in pubsub (#9)

* Prepare for alpha patch

* feat: run ci on pull requests too (#12)

Normal push events don't run from external repositories but pr events should.

* feat: 3 hour ttl on dynamodb tables (#13)

* Slight TTL tweaks (naming, defaults, consistent expiry)

* Fix ttl

* Prettier

* Add terraform config

* Add README and set up tf deployment

* Fix build ouptut + add logging

* Working messaging + dynamodb

* Working tf with ping/pong

* Update naming for exports

* Update README

Co-authored-by: Francis Gulotta <wizard@roborooter.com>
Co-authored-by: andyrichardson <email>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants