Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic deletion funcitonality #9

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

pehota
Copy link

@pehota pehota commented Apr 15, 2020

Add the ability to delete the highlighted branch by pressing d.
It's not possible to delete the current branch.

The functionality is very basic, it just force deletes branches.

@andys8
Copy link
Owner

andys8 commented Apr 15, 2020

Wow, cool.

I'm a bit cautious with deleting stuff. I don't want to make it too easy to avoid it happening by accident. What do you think about some kind of safety prompt?

@pehota
Copy link
Author

pehota commented Apr 16, 2020

I am with you on being cautious.
I just thought it might be a good idea to have the functionality in place and then iterate over it by:

  1. Adding a propmpt (default behaviour)
  2. Shift-d would skip the prompt and delete the branch straight away (for power users 💪)
  3. Eventually protect special branches (master, develop) although this is kinda debatable and maybe too much.

@andys8 andys8 merged commit 59b288e into andys8:master Apr 19, 2020
@pehota pehota deleted the feature/add-branch-deletion branch May 8, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants