This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
annex_scala_test #38
Merged
pauldraper
merged 3 commits into
higherkindness:master
from
lucidsoftware:pauldraper-test
Apr 17, 2018
Merged
annex_scala_test #38
pauldraper
merged 3 commits into
higherkindness:master
from
lucidsoftware:pauldraper-test
Apr 17, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctx.label started with @ and triggered recursive flagfile loading
pauldraper
force-pushed
the
pauldraper-test
branch
2 times, most recently
from
April 17, 2018 10:32
191350a
to
311fd65
Compare
andyscott
approved these changes
Apr 17, 2018
tests/tools/bazel.rc
Outdated
|
||
build --worker_sandboxing | ||
#build --worker_sandboxing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to leave these all commented out? (if yes-- why?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accident. I was trying to run down a problem with workers. (Turned out to be dfa0fa8)
Oops-- looks like we need to format the files. Otherwise LGTM. |
andyscott
suggested changes
Apr 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source formatting to fix CI breakage
Closed
pauldraper
force-pushed
the
pauldraper-test
branch
2 times, most recently
from
April 17, 2018 15:44
4772565
to
75aef4d
Compare
Support * sbt test frameworks * shard_count * --test_filter * java_stub_template * ANSI colors * verbosity controls Currently only works with zinc runner
pauldraper
force-pushed
the
pauldraper-test
branch
from
April 17, 2018 16:01
75aef4d
to
d402a47
Compare
bazel-io
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
May 3, 2018
Learnings gathered from JunitRunner (in implementing higherkindness/rules_scala#38) Closes #5041. PiperOrigin-RevId: 195206493
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See README.md for details