Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support node 18.1+ #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support node 18.1+ #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42b0f70
use emscripten/emsdk image for newer emscripten version to support no…
m59peacemaker Jun 17, 2023
9d3adc7
use emsdk 3.1.41 version explicitly, as building with emsdk 3.1.42 is…
m59peacemaker Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ echo 'Installing pkg-config'
apt-get install -y pkg-config

echo 'Linking emsdk directory...'
ln -s /emsdk_portable /opt/emsdk
ln -s /emsdk /opt/emsdk

echo 'Building MuPDF for wasm'
cd /src/platform/wasm && make
Expand Down
5 changes: 3 additions & 2 deletions bin/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { resolve } from "path";
import { Stream } from "stream";

const MUPDF_VERSION = "1.20.0";
const EMSDK_VERSION = "3.1.41";

async function main() {
await runDockerBuildCommand();
Expand All @@ -19,7 +20,7 @@ async function runDockerBuildCommand() {

console.log(`Running build command in docker container as user "${user}"`);
await docker.run(
"trzeci/emscripten",
`emscripten/emsdk:${EMSDK_VERSION}`,
["/opt/mupdf-js/bin/build.sh"],
process.stdout,
{
Expand All @@ -37,7 +38,7 @@ async function runDockerBuildCommand() {

function pullImage(docker: Docker) {
return new Promise((res, rej) => {
docker.pull("trzeci/emscripten", (err: any, stream: Stream) => {
docker.pull(`emscripten/emsdk:${EMSDK_VERSION}`, (err: any, stream: Stream) => {
if (err) {
console.error("Error");
return rej(err);
Expand Down