Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Smal fix) Can't install: Project name field in pyproject.toml doesn't follow pep0508 #10

Closed
stuaxo opened this issue Sep 12, 2023 · 5 comments

Comments

@stuaxo
Copy link

stuaxo commented Sep 12, 2023

https://peps.python.org/pep-0508/

I tried submitting a PR a couple of times, but I guess github is not happy today -

Installing locally with pip install -e . or python setup.py develop both failed, complaining about the name field

Lower casing the name, and replacing spaces with hyphens meant installation ran to completion.

$ pip install -e .
Obtaining file:///home/stu/projects/external/mrbenn
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... error
  error: subprocess-exited-with-error
  
  × Getting requirements to build editable did not run successfully.
  │ exit code: 1
  ╰─> [46 lines of output]
      configuration error: `project.name` must be pep508-identifier
      DESCRIPTION:
          The name (primary identifier) of the project. MUST be statically defined.
      
      GIVEN VALUE:
          "MrBenn Toolbar Plugin"
      
      OFFENDING RULE: 'format'
      
      DEFINITION:
          {
              "type": "string",
              "format": "pep508-identifier"
          }

...
@andytwoods
Copy link
Owner

Can you have a other go with creating a pull request. Will avoid potential errors. Thanks

@stuaxo
Copy link
Author

stuaxo commented Sep 13, 2023

Yeah it's weird - all the times I was trying from the github GUI. I'll try pushing up a branch tomorrow.

image

@andytwoods
Copy link
Owner

i've just pushed this name change. Thanks for spotting.

@andytwoods
Copy link
Owner

andytwoods commented Sep 13, 2023

released v2. No probs my end now.

@stuaxo
Copy link
Author

stuaxo commented Sep 13, 2023

Cheers, I'll pull this - no idea what was going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants