Switch to @aidemaster/node-memwatch #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2019
This reverts commit 9b24c7a.
|
Brandon, you are a life saver! Thank you so much! 😊 I mean f***ing memwstch still doesn’t compile on node 12 which goes into LTS in a month or so, but this is much better already! Will merge and release straight away when I get up in the morning. Great job finding that fork! 🙌 |
|
Thank you for all of your efforts! I think performance is still f00ked but I will double check. |
|
@andywer Yo, check this out. https://nodejs.org/api/v8.html#v8_v8_getheapsnapshot maybe you don't need the native module from memwatch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This compiles for node.js v10