Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require target to be set in plugin options #24

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Don't require target to be set in plugin options #24

merged 1 commit into from
Aug 20, 2020

Conversation

andywer
Copy link
Owner

@andywer andywer commented Aug 20, 2020 •
edited
Loading

Read target option from either plugin options or webpack options. Fixes andywer/threads.js#291.

@andywer andywer mentioned this pull request Aug 20, 2020
Closed
@andywer andywer merged commit 3e397bd into master Aug 20, 2020
@andywer andywer deleted the bugfix/webpack-resolver-error branch August 20, 2020 08:11
@andywer andywer changed the title Fix importing threads main entrypoint in worker Don't require target to be set in plugin options Aug 20, 2020
andywer added a commit that referenced this pull request Aug 20, 2020
@andywer
Update target setting docs
1a1b070 
Updates docs now that #24 has landed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't resolve 'child_process' in tiny-worker/lib
1 participant
@andywer