Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md examples #18

Merged
merged 1 commit into from
Jun 17, 2016
Merged

Conversation

andrakis
Copy link

@andrakis andrakis commented Jun 17, 2016

This corrects the examples in the README.md file so that they work out of the box.

It also adds a thread.kill() to the progression example so that the example finishes.

This resolves #17

@coveralls
Copy link

coveralls commented Jun 17, 2016

Coverage Status

Coverage remained the same at 97.368% when pulling 20d3d28 on andrakis:update_examples into 80da634 on andywer:master.

@andywer andywer merged commit fab7c8a into andywer:master Jun 17, 2016
@andywer
Copy link
Owner

andywer commented Jun 17, 2016

Thank you! But I am just now writing a very small change, so you can use .on('done'), too, since it's pretty convenient.

I guess I will just revert that one line. .on('message') seems counter-intuitive for progress-reporting threads...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

done event never gets called
3 participants