-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loaders updates (especially css-loader) #291
Conversation
Looks good. Could you please remove the
Yes. |
Great stuff, @marcofugaro! 🙌 I am just thinking that maybe we should now provide a postcss/cssnano configuration for the production build of the sample app, since the css-loader's |
@vlad-zhukov alright done, updated also the postcss block since there were no breaking changes with the new major version |
@andywer thanks! was wondering wether I should update also the I can set up the cssnano minification in this PR or another if you want, let me know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 We can add minification in another PR.
I updated all the most common dependencies to their latest version. Most of them have only minor updates, and so no breaking changes.
The two that had major updates are the file-loader (release) and the url-loader (release).
For the file-loader, I updated it anyway since webpack-blocks supports node6 to up as well.
For the css-loader, I had to handle the deprecation of the
minimize
option, I documented in the readme how to minify the css, and I updated the tests as best as I can.Let me know if I can handle the examples/tests in any better way. Also should I update the changelogs?