Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loaders updates (especially css-loader) #291

Merged
merged 8 commits into from
Aug 29, 2018

Conversation

marcofugaro
Copy link
Contributor

I updated all the most common dependencies to their latest version. Most of them have only minor updates, and so no breaking changes.

The two that had major updates are the file-loader (release) and the url-loader (release).

For the file-loader, I updated it anyway since webpack-blocks supports node6 to up as well.

For the css-loader, I had to handle the deprecation of the minimize option, I documented in the readme how to minify the css, and I updated the tests as best as I can.

Let me know if I can handle the examples/tests in any better way. Also should I update the changelogs?

@vlad-zhukov
Copy link
Collaborator

Looks good.

Could you please remove the yarn.lock file and run yarn again, this will re-resolve all dependencies and squash many of the new ones.

Also should I update the changelogs?

Yes.

@andywer
Copy link
Owner

andywer commented Aug 29, 2018

Great stuff, @marcofugaro! 🙌

I am just thinking that maybe we should now provide a postcss/cssnano configuration for the production build of the sample app, since the css-loader's minify is gone. Not necessarily blocking this PR, though 😉

@marcofugaro
Copy link
Contributor Author

@vlad-zhukov alright done, updated also the postcss block since there were no breaking changes with the new major version

@marcofugaro
Copy link
Contributor Author

@andywer thanks! was wondering wether I should update also the sampleapp, but noticed you didn't use any external blocks, only the core.

I can set up the cssnano minification in this PR or another if you want, let me know!

Copy link
Collaborator

@vlad-zhukov vlad-zhukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We can add minification in another PR.

@andywer andywer merged commit 697ec2c into andywer:release-2.0 Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants