Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #3

Closed
wants to merge 5 commits into from
Closed

Dev #3

wants to merge 5 commits into from

Conversation

Alfetta159
Copy link

Here is an expanded solution with corresponding projects for .NET Core 2.0.

  • I originally intended to use .NET Standard, but found just targeting .NET Core to be easier.
  • I ignored .NET Core 1.1 as it didn't not have all the capability to use existing source code.
  • Source code for the library is now in a shared project, but there are separate test projects.

I would like to see a single NuGet package which contains separate target folders in the lib folder (i.e. net4 & .netcoreapp20). There is no reason for a new separate NuGet package. However, I was unable (and admittedly unwilling) to go thru the Packager project to create that feature. I also use PS when creating packaging projects, but never get as complete and sophisticated as your code. (BTW, I find it interesting that VS 2017 has NuGet packaging built in, but I don't think that can be used for a NuGet package that has various framework targets (i.e. versions of .NET as well as versions of .NET Core).

Please consider using this as we depend on your code, but are having issues as the latest versions of VS are making it inconvenient to create dependencies on .NET framework from .NET Core based projects.

@Alfetta159
Copy link
Author

Actually, I don't want to merge into master, because the work on the packaging project should be completed first.

@andywilsonuk
Copy link
Owner

Hi Alfetta,

I've been putting off the .net core implementation due to other contraints however now that .net core 2 has been released I think it is worth creating a .net standard implementation which will sit alongside the .net framework version.

I will start looking at it this week hopefully.

Cheers
Andy

@andywilsonuk
Copy link
Owner

Hi Alfetta,

I've now completed the .net Standard 2.0 implementation and pushed version 1.7 to NuGet. You should be able to use this version with your .net core 2.0 application.

Cheers
Andy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants