Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib size is enormous 1.07Mb #53

Open
Stas-Buzunko opened this issue Dec 16, 2018 · 6 comments
Open

lib size is enormous 1.07Mb #53

Stas-Buzunko opened this issue Dec 16, 2018 · 6 comments
Assignees

Comments

@Stas-Buzunko
Copy link

Stas-Buzunko commented Dec 16, 2018

I'm sorry if it's me doing something wrong (but i doubt it)
But bundle size is huge due to react-coverflow size.
screenshot 2018-12-16 at 14 39 59
In my opinion, it's not ok for carousel library to take 47% of bundle size

@asalem1
Copy link
Collaborator

asalem1 commented Dec 20, 2018

Yikes, that is entirely too massive @Stas-Buzunko, I'll take a look at ways to reduce it's size ASAP. Thanks for bringing it to my attention

@asalem1 asalem1 self-assigned this Dec 20, 2018
@wzard
Copy link

wzard commented Jan 4, 2019

Hi @asalem1 , any updates on this one.

@asalem1
Copy link
Collaborator

asalem1 commented Jan 11, 2019

@wzard sorry, none so far. Just had a baby girl and haven't 19 days ago so i'm a little behind. I'll take a look at it soon

@wzard
Copy link

wzard commented Jan 12, 2019

@asalem1 Oh. Congratulations Asalem1. :) Take your time. Your baby needs you more than random internet strangers.

@asalem1
Copy link
Collaborator

asalem1 commented Jan 26, 2019

Thanks for the patience and for the well wishes. Just cleaned up webpack a bit, it's still higher than I'd like it to be so I'll keep this open but know that this is a serious concern that I'm currently address (along with the other issues). Thanks again for the support and patience

@asalem1
Copy link
Collaborator

asalem1 commented Mar 9, 2019

Alright, final update on this ticket. The published size has been reduced a bit, but it seems like the main culprit in the large dependency size is the radium dependency. My intent is to remove the dependency and see if I can replicate its functionality without losing performance. I'm going to leave this issue open until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants