Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: camera capture on Safari browser #2

Merged
merged 13 commits into from
Aug 2, 2023
Merged

Conversation

AshishKapoor
Copy link
Contributor

@AshishKapoor AshishKapoor commented Jul 25, 2023

Changelog

Camera Capture works on Safari browser with an ImageCapture Polyfill.

Ref: https://github.com/GoogleChromeLabs/imagecapture-polyfill

Screenshot 2023-07-25 at 10 49 28 AM

@AshishKapoor AshishKapoor changed the title Fixed the Camera Capture on Safari with an ImageCapture Polyfill fix: camera capture on Safari browser Jul 25, 2023
@andz-bb
Copy link
Owner

andz-bb commented Aug 2, 2023

thanks for the contribution @AshishKapoor! nice phone also ;)

I still had some trouble seeing the preview on iOS Safari but it works well on macOS. I'm going to be working a bit more on this component soon - do you have any requests or ideas of how to make it better? cheers

@andz-bb andz-bb merged commit 77bf7d6 into andz-bb:master Aug 2, 2023
@AshishKapoor
Copy link
Contributor Author

AshishKapoor commented Aug 2, 2023

thanks for the contribution @AshishKapoor! nice phone also ;)

I still had some trouble seeing the preview on iOS Safari but it works well on macOS. I'm going to be working a bit more on this component soon - do you have any requests or ideas of how to make it better? cheers

Thank you for creating this plugin!

It works on iOS for me.
image

Some ideas and questions

  • We need to fix the "Use Photo" button a bit. It populates the clicked pictures randomly as snapshots in grid view under the Camera stream.
  • Can we add validation to limit multiple photos count?
  • Also, can you tell me how I can render the saved photo in the JSON object format which includes the URL stored in the minio object store, onto the screen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants