mountable Express.js 4.x middleware #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of `require('./config')` everywhere, pass the configuration through.
…ting routes. Set up method-override to use POST body parameters.
…his way, when mongo-express is required within other modules, the middleware can be mounted.
…stead, set up the `baseHref` local attribute on the response object such that it ensures a trailing slash.
Upgrade consolidate to fix cache error in production (tj/consolidate.js#134).
|
Thanks for the pull request! |
andzdroid
added a commit
that referenced
this pull request
May 26, 2015
mountable Express.js 4.x middleware
ryodocx
pushed a commit
to ryodocx/mongo-express
that referenced
this pull request
Mar 18, 2019
mountable Express.js 4.x middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of changes allows mongo-express to be mounted as a sub-app within another Express 4 app. It also improves the general modularity of the module such that the config object can be passed through as an argument to the middleware, the router, and all of the routes. This makes it so that the only file that depends on
config.jsisapp.js, which won't be used when mounting as a middleware.