Fixed twig production cache setting #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@visionmedia 👍 This should be merged. (I've encountered this error as well) @rjarmstrong Can you remove your changes to |
tj
added a commit
that referenced
this pull request
Dec 21, 2013
Fixed twig production cache setting
|
It would be awesome if this year old bug were released. I already had in my code. I just spent 30 minutes hunting this down and manually hacking the line of code into my deployed libs just to get my app back up. |
|
+1 |
ifraixedes
added a commit
to ifraixedes/dev-toolbox
that referenced
this pull request
Apr 17, 2015
After I found an non npm update issue in `consolidate.js` for more than one year (tj/consolidate.js#134) I decided to use `swig` straightway. I also added `debug` for the sake of the console logging, added a new general use scaffolding middleware and passing configuration object to middlewares initialiser to be consistent with the dependency injection policy that I use. Express has been update to the last current production version
jeffreywescott
added a commit
to wisdomlabs/mongo-express
that referenced
this pull request
May 23, 2015
Upgrade consolidate to fix cache error in production (tj/consolidate.js#134).
veniversum
added a commit
to veniversum/crowdify
that referenced
this pull request
Jan 29, 2017
ryodocx
pushed a commit
to ryodocx/mongo-express
that referenced
this pull request
Mar 18, 2019
Upgrade consolidate to fix cache error in production (tj/consolidate.js#134).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The twig template engine does not take a parameter 'true' for cache settings. Rather the equivalent is 'memory'. Thus until this fix is made all production twig configurations will fail.