Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory is still lost when deathPunishment is set to keep #2194

Open
kdavid721 opened this issue Sep 14, 2022 · 1 comment
Open

Inventory is still lost when deathPunishment is set to keep #2194

kdavid721 opened this issue Sep 14, 2022 · 1 comment
Labels
status: new This issue is fresh!

Comments

@kdavid721
Copy link

Game Version: 1.17.3
Platform: Linux
Modded: No
SP/MP: Multiplayer

Description

Hi! I'm hosting a linux server (v1.17.3) and logging onto it with windows clients (also v1.17.3).
I set /worldconfig deathPunishment keep and restarted the server, but on death I still lose my inventory.

I checked the server directories and after setting deathPunishment,
there is a assets/survival/patches/keepinventory.json file created, it has the following contents:

[
  {
    "op": "add",
    "path": "/server/attributes",
    "value": {
      "keepContents": true
    },
    "file": "entities/humanoid/player.json",
    "condition": { "when": "deathPunishment", "isValue": "keep" },
    "side": "Server"
  }
]

So the setting is there, just not working.

How to reproduce

  1. Set up 1.17.3 linux server
  2. /worldconfig deathPunishment keep and restart
  3. join with 1.17.3 client
  4. Get bitten by wolves or die in other ways
  5. Inventory is lost

Expected behavior

Keep inventory on death.

Screenshots

Logs

These are probably not related, but I'm getting them while playing and there is a temporal rift nearby. I got these errors in the session where I tried the keep inventory setting.

14.9.2022 08:54:44 [Error] Exception thrown during handling event OnTrySpawnEntity: System.NullReferenceException: Object reference not set to an instance of an object
  at Vintagestory.GameContent.SystemTemporalStability.Event_OnTrySpawnEntity (Vintagestory.API.Common.IBlockAccessor blockAccessor, Vintagestory.API.Common.Entities.EntityPr
operties& properties, Vintagestory.API.MathTools.Vec3d spawnPosition, System.Int64 herdId) [0x000ba] in <f01e2cfb17af4d6e8438cdb4242c5d13>:0
  at Vintagestory.Server.ServerEventManager.TriggerTrySpawnEntity (Vintagestory.API.Common.IBlockAccessor blockaccessor, Vintagestory.API.Common.Entities.EntityProperties& p
roperties, Vintagestory.API.MathTools.Vec3d position, System.Int64 herdId) [0x00028] in <6215ae1029cd4696b4c4b2c34106b061>:0
14.9.2022 08:54:44 [Error] Exception thrown during handling event OnTrySpawnEntity: System.NullReferenceException: Object reference not set to an instance of an object
  at Vintagestory.GameContent.SystemTemporalStability.Event_OnTrySpawnEntity (Vintagestory.API.Common.IBlockAccessor blockAccessor, Vintagestory.API.Common.Entities.EntityPr
operties& properties, Vintagestory.API.MathTools.Vec3d spawnPosition, System.Int64 herdId) [0x000ba] in <f01e2cfb17af4d6e8438cdb4242c5d13>:0
  at Vintagestory.Server.ServerEventManager.TriggerTrySpawnEntity (Vintagestory.API.Common.IBlockAccessor blockaccessor, Vintagestory.API.Common.Entities.EntityProperties& p
roperties, Vintagestory.API.MathTools.Vec3d position, System.Int64 herdId) [0x00028] in <6215ae1029cd4696b4c4b2c34106b061>:0
14.9.2022 08:54:44 [Error] Exception thrown during handling event OnTrySpawnEntity: System.NullReferenceException: Object reference not set to an instance of an object
  at Vintagestory.GameContent.SystemTemporalStability.Event_OnTrySpawnEntity (Vintagestory.API.Common.IBlockAccessor blockAccessor, Vintagestory.API.Common.Entities.EntityPr
operties& properties, Vintagestory.API.MathTools.Vec3d spawnPosition, System.Int64 herdId) [0x000ba] in <f01e2cfb17af4d6e8438cdb4242c5d13>:0
@kdavid721 kdavid721 added the status: new This issue is fresh! label Sep 14, 2022
@tyronx
Copy link
Contributor

tyronx commented Sep 20, 2022

hm, i'm not able to reproduce this in a single player world

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: new This issue is fresh!
Projects
None yet
Development

No branches or pull requests

2 participants