Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellar food preservation broken #2755

Closed
oxxyjoe opened this issue May 19, 2023 · 15 comments
Closed

Cellar food preservation broken #2755

oxxyjoe opened this issue May 19, 2023 · 15 comments
Assignees
Labels
department: code Issues apparently caused by code priority: critical Severely impedes gameplay (crash loops, exploits, ...) status: confirmed Issue is acknowledged / can be reproduced status: resolved Job's done!

Comments

@oxxyjoe
Copy link

oxxyjoe commented May 19, 2023

Game Version

1.18.5

Platform

Windows

Modded

None

SP/MP

Singleplayer

Description

Food stored in cellars spoils much faster than normal since updating to 1.18.5.

Containers, crocks, bowls etc report a much longer time they will last than when you pick them up.

How to reproduce

Make a cellar of any size and place food in it. Tooltips show 0.28 rate of decay, but when you pick up the food it will have decayed at non-cellar rates, sometimes "spoiling immediately."

Screenshots

No response

Logs

Log

@oxxyjoe oxxyjoe added the status: new This issue is fresh! label May 19, 2023
@Craluminum2413
Copy link
Collaborator

Craluminum2413 commented May 19, 2023

What happens in cellar that have no doors?

@oxxyjoe
Copy link
Author

oxxyjoe commented May 19, 2023

What happens in cellar that have no doors?

My cellar had no door, so, this.

@DArkHekRoMaNT
Copy link
Collaborator

Containers, crocks, bowls etc report a much longer time they will last than when you pick them up.

Looks like normal behavior. The cellar bonus does not work for the player

@Craluminum2413 Craluminum2413 added status: incomplete Could need a little more information and removed status: new This issue is fresh! labels May 19, 2023
@radfast
Copy link

radfast commented May 19, 2023

I did make changes to containerchest and storage jar code in 1.18.5, may have broken something

@radfast radfast self-assigned this May 19, 2023
@oxxyjoe
Copy link
Author

oxxyjoe commented May 19, 2023

Containers, crocks, bowls etc report a much longer time they will last than when you pick them up.

Looks like normal behavior. The cellar bonus does not work for the player

Normal behavior is that it applies the cellar bonus to items you put in the cellar, rather than carry on you.
This is true I think. But this is not normal, rather, this is bugged, because, the "time left until it spoils" will say, for example, '5 days,' while sitting on the cellar floor, but when I picked it up, it will instantly change to "30% spoiled."
That is evidence that it is reporting to the player an incorrect "time left" value, and, that is indicating that the cellar bonus is not actually applying to the item.

@Craluminum2413
Copy link
Collaborator

That means that cellar bonus doesn't apply to items stored on the ground

@Echoweaver
Copy link

Echoweaver commented May 19, 2023

There's definitely something going on here. I expect when I pick up an item from the cellar that its spoilage time will advance when I pick it up. However, it should go back down when I put it back. That doesn't happen. I picked up a crock with 14 days left. It advanced to 7 days in my inventory. When I put it on the floor, it stayed at 7 days.

I've also picked up items that are listed as having several days of freshness left, and what is added to my inventory is rot.

This is happening with crocks and bowls, but I don't see it happening with pies. I thought it might only be happening with food stored in clay containers, and that might work with the theory about container code.

Our cellar has a door, btw.

I'm on a multiplayer server if that's relevant.

@radfast
Copy link

radfast commented May 20, 2023

Is anyone having this issue for fresh food not in containers (berries, meat etc)? Or only for crocks and bowls?

If it's crocks and bowls, does the issue happen if you don't place them on the ground, for example if you transfer directly from a storage vessel in the cellar to the player inventory?

@Prinzip
Copy link

Prinzip commented May 20, 2023

people complain that pots very quickly lose their durability. As a result, many pots have rotted in players, although on the rack the durability was still given. If you take the pot from the rack, all of a sudden it goes bad. since VS 1.18.5, also tested it in SP without mods. Here is an example:

1
2
3

@radfast
Copy link

radfast commented May 20, 2023

Thank you for all the reports.

Unfortunately, this is a new bug introduced in 1.18.5.

It applies only to crocks, bowls, cooking pots - basically any placeable/holdable food container. In contrast, your cheese and pies, and your raw and uncontained foods including bread and grains, should all be OK.

The bug only happens if the container is in a storage place which holds no raw or uncontained food

Essentially where the bug happens, cellar protection from spoilage gets retrospectively removed if the player picks up the container, so it will be as if the container had never been in a cellar. If its lifetime since being cooked has already gone past its normal base freshness (the freshness it would have in the player's hotbar for example) then it will instantly spoil when picked up.

Example:

  • a Cooking pot on the ground has the bug
  • a Crock on a shelf in a cellar has the bug
  • a Crock inside a Chest or Storage Vessel in a cellar - this can be OK (not bugged, freshness preserved) if the same Chest or Storage Vessel also holds some grain or vegetables

Therefore, until this is fixed, my advice to players is:

  • freshly cooked food (cooking pot / crock / bowl): store it in a Chest or Storage Vessel which also holds at least 1 item of grain of vegetables
  • existing food containers which are already in Chests or Storage Vessels - if there is grain or vegetables or raw meat also in the same Chest/Storage Vessel: your food is safe in this case, these food containers you can take out to eat or move around and use in other ways without loss of freshness, make sure to leave some grain permanently in this Chest/Storage Vessel to maintain the protection
  • existing food containers which are already in Chests or Storage Vessels - no grain / vegetables / meat etc in the same Chest/Storage Vessel: in this case basically you have the bug. If you like, you could add some grain or vegetables in 1 slot in the Chest or Storage Vessel, this will "fix" the bug for that Chest/Storage Vessel from this time forwards, but there will be some loss of freshness for the period before you took this step. Alternatively leave this food untouched and wait for the next hotfix
  • existing food in containers on the ground or on shelves (especially your long-term storage of sealed crocks, jams etc) - leave it where it is untouched until this bug is fixed If you move a food container from a position which has the bug in 1.18.5, the food will rapidly spoil

We will look to get a fixed version of the game out ASAP, I apologise that each recent "stable" version has had a serious bug.

TL;DR: The bug affects only crocks, bowls, cooking pots and similar containers, not raw food or pies. If any player takes a crock from a cellar in 1.18.5 that is past about 20% of its cellar life then it will be 'instantly spoiled' in the player's hands. The best thing you can do for now is:

  • place freshly cooked or recently cooked food which is in crocks, into a chest or Storage Vessel in the cellar with grain or vegetables in the same storage

  • for older food in crocks in a cellar, just leave it where it is without touching it, it will stay preserved in 1.18.5 according to the cellar's normal rules as long as it is not touched. Touching it (taking it or moving it) will likely get you a container full of rot, so there is no point touching it unless you need that container back.

@radfast radfast added status: confirmed Issue is acknowledged / can be reproduced priority: critical Severely impedes gameplay (crash loops, exploits, ...) department: code Issues apparently caused by code status: resolved Job's done! and removed status: incomplete Could need a little more information labels May 20, 2023
@oxxyjoe
Copy link
Author

oxxyjoe commented May 21, 2023

I started a new game in version 1.8.4, and, have just noticed that the issue is occurring to (at least) unsealed crocks in my single player world.

I had an unsealed crock of red meat stew that showed 9 days remaining, on a shelf in the cellar, and upon placing it on a regular stone block, it changed to only 5 hours. And upon replacing it to the shelf, it stayed at 5 hours.

I then picked up a sealed crock that had 1.6 years remaining,
placed it on the ground, then picked it up, and replaced it upon the shelf,
and it remained at 1.6 years remaining.

Thank you for addressing this and I'm glad to have noticed it.

@Dracoso18
Copy link

I just had this issue as well. It appears that when you pick up food, it readjusts to time passed since it was first made. I picked up a crock that read 10.1 hours left on a shelf. It immediately went to 100% spoiled. Several crocks at 15-18 days remaining jumped down to between 20 hours and 3.1 days. my friend and I had to stop playing because i was watching our food rapidly go bad across the board.

Some of the food i made recently which were at 23 days would drop to 21 days if I picked them up. Because of this, i think the food is: 1. when picked up, it jumps to as if it had been at 100% spoil rate since it was first made and calculates the remaining time left, updating the current spoilage rate to that time 2. when placed back down, it shows the updated time and then acts as if the preservation rate is correct in the cellar. 3. if picked up again, it recalculates and adjusts again to the 100% rate update.

@radfast
Copy link

radfast commented May 24, 2023

For now, the recommendation is:

(1) leave existing crocks untouched on shelves, until Vintage Story version 1.18.6 is released (likely in the next 3 days, no guarantee)

(2) Place new crocks (and bowls and cooking pots) which you want to preserve, into Chests or Storage Vessels which also hold some grain. The game code which preserves the grain for longer will also preserve the crocks for longer, if they are inside the same storage.

In multiplayer, you can maybe also try bugging your server admin to update the server to a hotfixed version which already fixes this (see thread in Multiplayer channel on Discord) but the server admin would need Linux, .NET7 and the ability to update the game version between official releases, not all server admins can do that.

@Guimoute
Copy link

Hello,

There seems to be more at play than expiration date issues. Like everyone else I picked up crocks and their content rotted instantly, but I also got a different behavior where the content disappears altogether instead of rotting. Please see below:

2023-05-31.21-00-38_5120kb_output.mp4

@tyronx
Copy link
Contributor

tyronx commented Jul 23, 2023

this should be fixed in 1.18.6

@tyronx tyronx closed this as completed Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
department: code Issues apparently caused by code priority: critical Severely impedes gameplay (crash loops, exploits, ...) status: confirmed Issue is acknowledged / can be reproduced status: resolved Job's done!
Projects
None yet
Development

No branches or pull requests

9 participants