Allow null datetimes (NoneType) #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiallRees
force-pushed
the
allow_null_dates
branch
from
f9c7d19
to
657c720
Compare
daigotanaka
requested changes
Nov 18, 2020
NiallRees
force-pushed
the
allow_null_dates
branch
from
657c720
to
e205bbc
Compare
daigotanaka
requested changes
Nov 19, 2020
NiallRees
force-pushed
the
allow_null_dates
branch
from
b54e21f
to
65fd8fb
Compare
|
Thanks for the reviews @daigotanaka |
daigotanaka
requested changes
Nov 19, 2020
NiallRees
force-pushed
the
allow_null_dates
branch
from
b5db42f
to
cf9898f
Compare
|
@NiallRees Thx! Great job! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all our BigQuery tables, timestamp columns are nullable. This was causing the tap to fail as a NoneType datetime field was raising this ValueError. This PR allows datetime fields to be None.