-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SYSENG-678 ✨: Implement clouddns/zone API with generic client #82
Conversation
fa6184c
to
ec5d894
Compare
b1271c0
to
8c378bc
Compare
Codecov Report
@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 55.84% 56.04% +0.20%
==========================================
Files 93 95 +2
Lines 4072 4177 +105
==========================================
+ Hits 2274 2341 +67
- Misses 1433 1459 +26
- Partials 365 377 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
ac0c028
to
9bdbc0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some minor things I will happily fix once you confirm them :)
All in all it looks good
561d2aa
to
2f461a4
Compare
I've addressed the issues you pointed out, thanks for that :) Feel free to squash and merge as you see fit. |
This adds a new package for parts of the Anexia CloudDNS zone management API based on the generic client.
Also added magic comments for Zone and Record and the code generated from them.
d892daf
to
5b40a78
Compare
Want to check my two added commits @toothstone? Please merge when they lgty :) |
5b40a78
to
06382e1
Compare
Description
This adds a new package for parts of the Anexia CloudDNS zone management
API based on the generic client.
Release Note
Release note for CHANGELOG: