Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYSENG-678 ✨: Implement clouddns/zone API with generic client #82

Merged
merged 5 commits into from
Dec 3, 2021

Conversation

toothstone
Copy link
Contributor

Description

This adds a new package for parts of the Anexia CloudDNS zone management
API based on the generic client.

Release Note

Release note for CHANGELOG:

ADDED
* New Anexia CloudDNS zone management API implementation based on the generic client

@toothstone toothstone marked this pull request as draft November 23, 2021 09:02
@toothstone toothstone force-pushed the SYSENG-678/clouddnsv2 branch 2 times, most recently from b1271c0 to 8c378bc Compare November 23, 2021 09:24
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #82 (5b40a78) into main (29d3291) will increase coverage by 0.20%.
The diff coverage is 63.80%.

❗ Current head 5b40a78 differs from pull request most recent head 06382e1. Consider uploading reports for the commit 06382e1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   55.84%   56.04%   +0.20%     
==========================================
  Files          93       95       +2     
  Lines        4072     4177     +105     
==========================================
+ Hits         2274     2341      +67     
- Misses       1433     1459      +26     
- Partials      365      377      +12     
Flag Coverage Δ
integration 44.23% <ø> (ø)
unittests 29.37% <63.80%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apis/clouddns/v1/zone_genclient.go 63.63% <63.63%> (ø)
pkg/apis/clouddns/v1/record_genclient.go 64.00% <64.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d3291...06382e1. Read the comment docs.

@toothstone toothstone marked this pull request as ready for review November 23, 2021 09:51
@LittleFox94

This comment has been minimized.

@LittleFox94 LittleFox94 force-pushed the SYSENG-678/clouddnsv2 branch 2 times, most recently from ac0c028 to 9bdbc0b Compare November 29, 2021 15:02
Copy link
Contributor

@LittleFox94 LittleFox94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some minor things I will happily fix once you confirm them :)

All in all it looks good

pkg/apis/clouddns/v1/record_types.go Outdated Show resolved Hide resolved
pkg/apis/clouddns/v1/zone_genclient.go Show resolved Hide resolved
pkg/apis/clouddns/v1/zone_types.go Outdated Show resolved Hide resolved
@toothstone
Copy link
Contributor Author

I've addressed the issues you pointed out, thanks for that :)

Feel free to squash and merge as you see fit.

toothstone and others added 5 commits December 1, 2021 13:45
This adds a new package for parts of the Anexia CloudDNS zone management
API based on the generic client.
Also added magic comments for Zone and Record and the code generated from them.
@LittleFox94
Copy link
Contributor

Want to check my two added commits @toothstone? Please merge when they lgty :)

@LittleFox94 LittleFox94 self-requested a review December 1, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants