SYSENG-1659: add frontier resources #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
force-pushed
the
SYSENG-1659/add-frontier-resources
branch
11 times, most recently
from
eca0a49
to
ae952ba
Compare
|
Depends on #140 and anexia-it/go-anxcloud#311
|
89Q12
reviewed
Nov 9, 2023
There was a problem hiding this comment.
Test CRUD operations on the added frontier resources, works as expected.
Aside from some weird error messages that the engine gives, e.g when a E5E function does not exist, it spits out a 404, which might cause confusion. Maybe we should document that somewhere?
Otherwise LGTM 👍
|
Forgot to mention it in above comment, could you take a look at the codeclimate issues and fix them? |
ghost
force-pushed
the
SYSENG-1659/add-frontier-resources
branch
2 times, most recently
from
014e4f4
to
29afd39
Compare
89Q12
previously approved these changes
Nov 13, 2023
ghost
commented
Nov 14, 2023
ghost
commented
Nov 15, 2023
ghost
force-pushed
the
SYSENG-1659/add-frontier-resources
branch
from
29afd39
to
04f2884
Compare
|
looks good to me, successfully tested 👍 |
ORW-3
previously approved these changes
Nov 16, 2023
ghost
force-pushed
the
SYSENG-1659/add-frontier-resources
branch
2 times, most recently
from
a7f2f11
to
4aacb0a
Compare
ghost
marked this pull request as ready for review
89Q12
previously approved these changes
Mar 13, 2024
ghost
force-pushed
the
SYSENG-1659/add-frontier-resources
branch
from
4aacb0a
to
3e137d3
Compare
89Q12
approved these changes
Mar 20, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added resources to manage the frontier service:
anxcloud_frontier_apianxcloud_frontier_endpointanxcloud_frontier_actionanxcloud_frontier_deploymentChecklist
Unreleasedsection in CHANGELOG.md, if user facing changeReferences
Community Note