Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue on auto discovery #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

f4iha
Copy link

@f4iha f4iha commented May 22, 2021

Fixed the issue with the autodiscovery, the service_matches is having a length of 0, however if we set the param host from the discovered addr and the port at 1 it is fixing the problem

@anfractuosity
Copy link
Owner

Thanks for your pull request!, will try and test this soon

@anfractuosity
Copy link
Owner

Hi,

I've just added a couple more validation checks, to make sure that an address is obtained either from a parameter or
it's obtained by searching for it.

Unfortunately during my current testing, I can't seem to trigger the line:
print("No services found for address ", addr, file=sys.stderr)

I'll try again, to see if I can get it to trigger, to see if your pull request fixes it for me.

Thanks

@f4iha
Copy link
Author

f4iha commented Jun 28, 2021

You will not see the line No services found for address appearing as I removed this part of the code and replaced by a static information.
Instead of having the error message and quit the code, I updated the code in order to use the same behavior as using the --addr <ADDRESS> with a specific ADDRESS defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants