Skip to content
This repository has been archived by the owner on Apr 26, 2021. It is now read-only.

Response is not stooped on 404 #42

Closed
fredtma opened this issue Jun 21, 2017 · 4 comments
Closed

Response is not stooped on 404 #42

fredtma opened this issue Jun 21, 2017 · 4 comments

Comments

@fredtma
Copy link
Contributor

fredtma commented Jun 21, 2017

On an angel init project 1 (full project), if you target nonexisting resource e.g http://localhost:3000/notFound, you will get an endless pending resource.

in lib/src/routes/routes.dart if you use comment out the exception handling and use

app.after.add((ResponseContext res) => 'Not Found');

This will work but the current way it is setup with the default template does not work event though the error is caught.
online 28 in the file plugin.dart whether I variable result with a bool value of false or a Map back the request does not end.

@thosakwe
Copy link
Member

Thanks. I made a change to the way errors are handled, and I think it broke some things. Going to revert it today.

@thosakwe
Copy link
Member

Not going to be home for a few days. For now, please downgrade to angel_framework <= 1.0.3

@thosakwe
Copy link
Member

@fredtma I was able to find where this bug came from, and it's been fixed with this commit: angel-dart-archive/framework@58ec66f

I'm aiming to publish v1.0.6 of package:angel_framework tonight.

@thosakwe
Copy link
Member

Resolved!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants