Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't parse .uk.com domains #1

Closed
KevSex opened this issue May 6, 2018 · 2 comments
Closed

Doesn't parse .uk.com domains #1

KevSex opened this issue May 6, 2018 · 2 comments
Assignees

Comments

@KevSex
Copy link

KevSex commented May 6, 2018

Hey,

Had an issue whereby it wouldn't work with my .uk.com domain.

Looks like when its trying to get the ZONENAME_REGEX, it returns uk\.com.
This occurs when the CERBOT_DOMAIN is *.domain.uk.com

I also had to add in a sleep as it wasn't picking it up within the short space of time. After this, it worked great.

Also to note, --manual-cleanup-hook was required to remove the record once complete, not sure if its worth updating the examples shown.

@angel333
Copy link
Owner

angel333 commented May 8, 2018

Indeed, the regex seems to only support second level domains.

I'm afraid I'll not be able to find time to fix it now. In the meantime, however, I recommend that you try acme.sh for which I also wrote a HE plugin. It's much more polished and I'm pretty sure I've tested domains of deeper levels (HE supports adding zones for subdomains). I actually plan to incorporate code from the acme.sh plugin back to this certbot plugin.

I've added the forgotten manual-cleanup-hook into examples, thanks.

@angel333 angel333 self-assigned this May 9, 2018
@angel333
Copy link
Owner

angel333 commented Oct 3, 2018

Hey KevSex,

I've briefly tested and it seems to be working now, but let me know if there's still an issue.

Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants