Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for subdomains #2

Closed
wants to merge 1 commit into from
Closed

Conversation

tgarbin
Copy link

@tgarbin tgarbin commented Sep 15, 2018

This will find all . in $CERTBOT_DOMAIN and escape it. e.g foo\.bar\.example\.com

This should resolve issue #1

This will find all `.` in $CERTBOT_DOMAIN and escape it. e.g `foo\.bar\.example\.com`
@angel333
Copy link
Owner

angel333 commented Oct 3, 2018

Hi tgarbin,

I haven't really tried this commit but it looks to me it would break subdomains within zones. See 05fc536 for the solution I went with eventually.

Thank you for your time and effort though!

@angel333 angel333 closed this Oct 18, 2018
@tgarbin
Copy link
Author

tgarbin commented Oct 18, 2018

Hi angel333,

I haven't had a chance to properly look over your commit but I appreciate the feedback.

There'll be something there for me to learn. Thanks a lot for providing this repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants