Merge pull request #1386 from angelleye/PFW-516

make Minicart by default disable, PFW-516
angelleye · Nov 5, 2019 · 9b9bd29 · 9b9bd29
2 parents 4716dfd + 72310cd
commit 9b9bd29
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/angelleye-includes/express-checkout/class-wc-gateway-paypal-express-helper-angelleye.php b/angelleye-includes/express-checkout/class-wc-gateway-paypal-express-helper-angelleye.php
@@ -60,7 +60,7 @@ public function __construct() {
                 $this->show_on_checkout = !empty($this->setting['show_on_checkout']) ? $this->setting['show_on_checkout'] : 'top';
                 $this->button_position = !empty($this->setting['button_position']) ? $this->setting['button_position'] : 'bottom';
                 $this->show_on_cart = !empty($this->setting['show_on_cart']) ? $this->setting['show_on_cart'] : 'yes';
-                $this->show_on_minicart = !empty($this->setting['show_on_minicart']) ? $this->setting['show_on_minicart'] : 'yes';
+                $this->show_on_minicart = !empty($this->setting['show_on_minicart']) ? $this->setting['show_on_minicart'] : 'no';
                 $this->prevent_to_add_additional_item_value = !empty($this->setting['prevent_to_add_additional_item']) ? $this->setting['prevent_to_add_additional_item'] : 'no';
                 $this->prevent_to_add_additional_item = 'yes' === $this->prevent_to_add_additional_item_value;
                 $this->testmode_value = !empty($this->setting['testmode']) ? $this->setting['testmode'] : 'yes';

diff --git a/classes/wc-gateway-paypal-express-angelleye.php b/classes/wc-gateway-paypal-express-angelleye.php
@@ -126,7 +126,7 @@ public function __construct() {
         $this->fraud_management_filters = $this->get_option('fraud_management_filters', 'place_order_on_hold_for_further_review');
         $this->invoice_id_prefix = $this->get_option('invoice_id_prefix', '');
         $this->paypal_marketing_solutions_cid_production = $this->get_option('paypal_marketing_solutions_cid_production', '');
-        $this->show_on_minicart = $this->get_option('show_on_minicart', 'yes');
+        $this->show_on_minicart = $this->get_option('show_on_minicart', 'no');
         $this->pending_authorization_order_status = $this->get_option('pending_authorization_order_status', 'On Hold');
         $this->enable_in_context_checkout_flow = $this->get_option('enable_in_context_checkout_flow', 'yes');
         if ($this->enable_notifyurl == 'yes') {
@@ -778,7 +778,8 @@ public function init_form_fields() {
                 'title' => __('Minicart', 'paypal-for-woocommerce'),
                 'label' => __('Show Express Checkout button in the WooCommerce Minicart.', 'paypal-for-woocommerce'),
                 'type' => 'checkbox',
-                'default' => 'yes'
+                'default' => 'no',
+                'description' => __('Enabling this option will cause the PayPal button JS to load on every page, which could negatively affect page load times on your site.'),
             ),
             'button_position' => array(
                 'title' => __('Cart Button Position', 'paypal-for-woocommerce'),