Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST CC Logs are not secure..?? #1125

Closed
angelleye opened this issue May 16, 2018 · 7 comments
Closed

REST CC Logs are not secure..?? #1125

angelleye opened this issue May 16, 2018 · 7 comments
Assignees
Labels
Milestone

Comments

@angelleye
Copy link
Collaborator

We’re in sandbox mode right now, and under the REST settings under Woocommerce -> Settings -> Checkout, we have NOT enabled logging. However, I can see all transactions made since May 1st in the wc-log, with all credit card details, first and last name, address, etc. shown there in plain text!

Is this happening because logging is defaulted to “on” when in sandbox mode or something? When we go to live payments will wc-logs still be made like this?

@iMansoorAliKhan
Copy link

@kcppdevelopers I have just installed Dev branch on my sandbox site
deleted all old logs, deactivated logging in REST and all other methods. The performed a few orders.
Log is still being generated even though I have disabled that in plugin settings.

@angelleye
Copy link
Collaborator Author

@kcppdevelopers I see you made a commit after @iMansoorAliKhan's last message, but you didn't mark this ready for review again. Are you still working on this?

@angelleye
Copy link
Collaborator Author

@kcppdevelopers The cf648e7 commit above has Braintree stuff in it. Why was that commit done here?

@iMansoorAliKhan
Copy link

iMansoorAliKhan commented May 21, 2018

CC log now shows this?

image

is that all the information we are going to logg??

@iMansoorAliKhan
Copy link

REST automatic log creation is now fixed...
it only generates log when we enable from settings page.

@kcppdevelopers
Copy link
Contributor

@iMansoorAliKhan Yes it is expected behavior, it will display full log when Notice/Error on response.

@iMansoorAliKhan
Copy link

so no details when its success ???

angelleye pushed a commit that referenced this issue May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants