New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express Checkout - Adjust button on product details page. #208

Closed
angelleye opened this Issue May 27, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@angelleye
Owner

angelleye commented May 27, 2015

Right now when you click the Express Checkout button from a product page it adds the item to the cart prior to setting up the PayPal request and redirecting to PayPal. If the item is already in the cart, it adds an additional unit.

This becomes an issue when the product is set to "sold individually" in WooCommerce. If this sort of item is already in the cart when you click the PayPal EC button on the product page then it just returns an error about the item already being added to the cart and it doesn't actually move forward to PayPal.

For more details review the following support thread.

https://wordpress.org/support/topic/weird-mix-between-checkout-with-paypal-and-add-to-cart?replies=9#post-6998054

@angelleye angelleye added the bug label May 27, 2015

@angelleye angelleye added this to the 1.1.6.4 milestone May 27, 2015

@angelleye angelleye modified the milestones: 1.1.6.4, 1.1.6.5 Jun 23, 2015

@angelleye angelleye modified the milestones: 1.1.6.4, 1.2 Jul 1, 2015

@nishitlangaliya

This comment has been minimized.

Show comment
Hide comment
@nishitlangaliya

This comment has been minimized.

Show comment
Hide comment
@nishitlangaliya

nishitlangaliya Aug 5, 2015

Hi Andrew,

I see the comment and read "https://wordpress.org/support/topic/weird-mix-between-checkout-with-paypal-and-add-to-cart?replies=9#post-6998054"

from that thread what I understood is here user has a problem that even if the product is set as "individual sold" . using our plugin's express checkout button user is able to add that product more than one time am I right ? if yes then I have prepared one video from my local server and user's website for test the case.

In that testing I was not able to add individual sold product more than one time using our expresschekout button.

Please see below URL when you get a chance and let me know your thoughts for the same.

URL : http://www.screencast.com/t/ODXStPit8kwf

nishitlangaliya commented Aug 5, 2015

Hi Andrew,

I see the comment and read "https://wordpress.org/support/topic/weird-mix-between-checkout-with-paypal-and-add-to-cart?replies=9#post-6998054"

from that thread what I understood is here user has a problem that even if the product is set as "individual sold" . using our plugin's express checkout button user is able to add that product more than one time am I right ? if yes then I have prepared one video from my local server and user's website for test the case.

In that testing I was not able to add individual sold product more than one time using our expresschekout button.

Please see below URL when you get a chance and let me know your thoughts for the same.

URL : http://www.screencast.com/t/ODXStPit8kwf

@nishitlangaliya

This comment has been minimized.

Show comment
Hide comment
@nishitlangaliya

nishitlangaliya Aug 5, 2015

Hi Andrew,

Here What Other things I understood is. as per your comment you mean that if the product is "sold individual" and already added to cart than instead of giving the error on product page it should redirect to paypal without adding that product second time into cart am I right ?

and if the product type is not " sold individual" than it should add to cart and redirect to paypal is it right ?.

so I have done code according to it and pushed code to Issue-208 branch for a review.

nishitlangaliya commented Aug 5, 2015

Hi Andrew,

Here What Other things I understood is. as per your comment you mean that if the product is "sold individual" and already added to cart than instead of giving the error on product page it should redirect to paypal without adding that product second time into cart am I right ?

and if the product type is not " sold individual" than it should add to cart and redirect to paypal is it right ?.

so I have done code according to it and pushed code to Issue-208 branch for a review.

@angelleye angelleye modified the milestones: 1.1.7.6, 1.2 Dec 26, 2015

@angelleye

This comment has been minimized.

Show comment
Hide comment
@angelleye

angelleye Dec 26, 2015

Owner

Need to review this and see if the commits made are good or if you need to make any adjustments. Please handle and test accordingly.

Owner

angelleye commented Dec 26, 2015

Need to review this and see if the commits made are good or if you need to make any adjustments. Please handle and test accordingly.

@kcppdevelopers

This comment has been minimized.

Show comment
Hide comment
@kcppdevelopers

kcppdevelopers Dec 29, 2015

Collaborator

I have push latest code in issue-208-B branch.

Collaborator

kcppdevelopers commented Dec 29, 2015

I have push latest code in issue-208-B branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment