Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Settings Panel #214

Closed
angelleye opened this issue Jun 12, 2015 · 7 comments
Closed

Plugin Settings Panel #214

angelleye opened this issue Jun 12, 2015 · 7 comments
Assignees
Milestone

Comments

@angelleye
Copy link
Collaborator

Currently, our plugin settings are all done through WooCommerce -> Settings -> Checkout tab.
#174 adds a product specific setting and we need a tool similar to what we did in Offers for WooCommerce to manage it. It's time for our own settings panel.

For this issue, let's go ahead and get our own settings panel setup under Settings -> PayPal for WooCommerce in the WP admin panel. Just prepare a "General" tab and maybe a "Tools" tab, and within the general tab we can have links to the current checkout settings pages.

@angelleye angelleye added this to the 1.1.6.4 milestone Jun 12, 2015
jigneshkailam added a commit that referenced this issue Jun 16, 2015
@jigneshkailam
Copy link
Contributor

I am done with Plugin Settings Panel and push to issue branch for your review.

@angelleye angelleye modified the milestones: 1.1.6.4, 1.1.6.5 Jun 23, 2015
@angelleye angelleye modified the milestones: 1.1.6.4, 1.2 Jul 1, 2015
@angelleye
Copy link
Collaborator Author

I had to resolve a merge conflict here, which I think I did correctly. Everything seems to be working as expected except for one thing.

When I first enter our new settings panel via Settings -> PayPal for WooCommerce, I see this error under the Express Checkout tab, and the link to the current settings page does not display:

image

If I click to one of the other tabs, though, and then click back it works fine:

image

Each time I leave the settings page and come back the same thing happens.

@angelleye
Copy link
Collaborator Author

We also need to add a new tab for PayPal Plus (Germany) which is now available in the plugin.

@angelleye
Copy link
Collaborator Author

I'm getting a conflict when I try to merge Issue-214-A into the release branch. Please merge the release branch into Issue-214-A and resolve the conflict.

@kcppdevelopers
Copy link
Contributor

I have resolved conflict and push issue-214-B branch into the release branch.

@angelleye
Copy link
Collaborator Author

I am not getting the error anymore, but now the Express Checkout tab content still does not display when I first load it.

I go to Settings -> PayPal for WooCommerce, and this is what I see:

image

If I then click to one of the other tabs, and back to the Express Checkout tab, then I do get the content I expect, like this:

image

@angelleye angelleye reopened this Dec 26, 2015
kcppdevelopers added a commit that referenced this issue Dec 26, 2015
@kcppdevelopers
Copy link
Contributor

I make it correct and push the latest code into the release branch.

@angelleye angelleye modified the milestones: 1.2, 1.1.7.6 Dec 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants