-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin Settings Panel #214
Comments
I am done with Plugin Settings Panel and push to issue branch for your review. |
I had to resolve a merge conflict here, which I think I did correctly. Everything seems to be working as expected except for one thing. When I first enter our new settings panel via Settings -> PayPal for WooCommerce, I see this error under the Express Checkout tab, and the link to the current settings page does not display: If I click to one of the other tabs, though, and then click back it works fine: Each time I leave the settings page and come back the same thing happens. |
We also need to add a new tab for PayPal Plus (Germany) which is now available in the plugin. |
I'm getting a conflict when I try to merge Issue-214-A into the release branch. Please merge the release branch into Issue-214-A and resolve the conflict. |
I have resolved conflict and push issue-214-B branch into the release branch. |
I am not getting the error anymore, but now the Express Checkout tab content still does not display when I first load it. I go to Settings -> PayPal for WooCommerce, and this is what I see: If I then click to one of the other tabs, and back to the Express Checkout tab, then I do get the content I expect, like this: |
I make it correct and push the latest code into the release branch. |
Currently, our plugin settings are all done through WooCommerce -> Settings -> Checkout tab.
#174 adds a product specific setting and we need a tool similar to what we did in Offers for WooCommerce to manage it. It's time for our own settings panel.
For this issue, let's go ahead and get our own settings panel setup under Settings -> PayPal for WooCommerce in the WP admin panel. Just prepare a "General" tab and maybe a "Tools" tab, and within the general tab we can have links to the current checkout settings pages.
The text was updated successfully, but these errors were encountered: