Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide PayPal buttons when currency is unsupported. #285

angelleye opened this issue Aug 26, 2015 · 0 comments


Copy link

commented Aug 26, 2015

PayPal provides a list of supported currency codes.

Right now if the order is in this currency our plugin sends it to PayPal and returns the error that the currency is unsupported. We should add logic to hide the PayPal buttons if the currency is unsupported so that we can avoid this error altogether.

The PayPal library that we're using in this plugin has a $CurrencyCodes array included with it. We should double check that it's still accurate with the list PayPal provides, and then it can be used to easily cross-reference in the code logic in order to hide buttons if the currency code is not in the list.

@angelleye angelleye added this to the 1.2.1 milestone Aug 26, 2015
@angelleye angelleye modified the milestones: 1.2.1, 1.2.2, 1.2.3, 1.2.4 Jun 18, 2016
@angelleye angelleye modified the milestones: 1.2.4, 1.2.5 Jun 29, 2016
angelleye added a commit that referenced this issue Aug 6, 2016
@angelleye angelleye closed this Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.